-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brackets in data URI cause url reducer to parse incorrectly #633
Labels
Comments
That's a bug then. If possible you can use |
jakubpawlowicz
added a commit
that referenced
this issue
Aug 5, 2015
We need to identify cases when data URI are escaped (and brackets are not) so we can get the whole URI.
jakubpawlowicz
added a commit
that referenced
this issue
Aug 5, 2015
We need to identify cases when data URI are escaped (and brackets are not) so we can get the whole URI.
Closed
jakubpawlowicz
added a commit
that referenced
this issue
Aug 9, 2015
The fix to #633 included a regression in URI processing as the algorithm introduced should only be applied to data URIs.
jakubpawlowicz
added a commit
that referenced
this issue
Aug 9, 2015
The fix to #633 included a regression in URI processing as the algorithm introduced should only be applied to data URIs.
jakubpawlowicz
added a commit
that referenced
this issue
Aug 9, 2015
The fix to #633 included a regression in URI processing as the algorithm introduced should only be applied to data URIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This very basic SVG image:
... when whitespace is stripped and data URI'd correctly becomes:
When using this data URI as a
background-image
, CleanCSS chokes on the brackets used by thetranslate
function and generates malformed CSS by dropping the quotes inside theurl()
.This happens in the
byUrl
function in theurls/reduce
module, so specifying compatibility options like{ compatibility: { properties: { urlQuotes: true } } }
to CleanCSS doesn't help.The text was updated successfully, but these errors were encountered: