Add instructions to get Dockerfile working #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2014 15:42
We want to make sure people don't accidentally commit their config files when opening pull-requests and such
From my investigation using a bash session on the Dockerfile, cloudtunes-server never started with superviser because it would always fail with: ``` !!!Cannot import local settings!!! You need to copy cloudtunes/settings/local.example.py to cloudtunes/settings/local.py and fill in the None's. https://github.com/jakubroztocil/cloudtunes#installation ```
|
Any chance to pass API key/secret through env docker system like Storing API information inside docker image will stuck the image to a personal usage and not reusable like docker philosophy. |
| @@ -1,4 +1,5 @@ | |||
| dump.rdb | |||
| .idea/ | |||
| *.pyc | |||
|
|
|||
| # Make sure people dont accidentally commit their API keys! | |||
| cloudtunes-server/cloudtunes/settings/local.py | |||
There was a problem hiding this comment.
It's already excluded in cloudtunes-server/.gitignore
added 2 commits
September 23, 2014 07:39
jkbrzt
added a commit
that referenced
this pull request
Sep 23, 2014
Add instructions to get Dockerfile working
|
Thanks, Peter 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruction to get Dockerfile working 👍