Implement msgpack support #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support content types with binary data, there are two different modifications needed: 1) We need to postpone response body decoding into unicode until the output processor is run. Making it before (with the 'replace' substitution policy) would mean scrambling the binary data. 2) We need to postpone the binary check (used for output suppression) until the output processors have run. In fact, binary processors might decode the data into something readable that doesn't need to be suppressed.
5 tasks
|
Thanks, @rasky! It looks useful. It would be better to have this as a plugin though since it has an external dependency. I'm already planning on adding a plugin API also for output processors like this one. See #177. |
|
OK I'm happy to adapt the code once you have the plugin API out for this. Let me know how it goes. |
jkbrzt
force-pushed
the
master
branch
3 times, most recently
from
518c743
to
24f46ff
Compare
|
Resubmitted as #284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements support for msgpack (http://msgpack.org).
MsgPack is a binary transport for schemaless data structures. It can be thought as a binary serialization of JSON, though this is not formally a correct definition. MsgPack is very popular in Japan and is increasingly used as a compact serialization / data storage format.
The present patch makes httpie understands the "application/x-msgpack" content type, and decode it appropriately to the standard output. It is very useful when working with an API that implements this serialization format.
Testsuite is OK after this patch is applied.