Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for HTTP methods #332

Closed
wants to merge 1 commit into from
Closed

Conversation

mihirvj
Copy link
Contributor

@mihirvj mihirvj commented Mar 27, 2015

See #331

I think before we finalize the pythonic method for this, these changes can be utilized.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 92.12% when pulling 7a3a73c on mihirvj:master into 483546d on jakubroztocil:master.

@sigmavirus24
Copy link

Can you change the commit message (and title) to read:

"Added completion support for HTTP methods"

The message is very misleading otherwise.

@jkbrzt
Copy link
Member

jkbrzt commented Mar 27, 2015

@mihirvj I'd also add PATCH, OPTIONS, and I believe there are other commonly used methods as well

@jkbrzt
Copy link
Member

jkbrzt commented Mar 27, 2015

Now I realize this will only work without any --options (e.g. $ http -v P<tab> wont complete).

The more robust approaches mentioned in #331 are probably a better way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants