Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport attribute management to 2.5 #38

Closed
jdecool opened this issue Mar 31, 2023 · 4 comments
Closed

Backport attribute management to 2.5 #38

jdecool opened this issue Mar 31, 2023 · 4 comments

Comments

@jdecool
Copy link

jdecool commented Mar 31, 2023

Since it could be not trivial to migrate from PHPUnit 9 to 10, it could be very interesting to use attributes.

But it's only available in 3.0 which is compatible with PHPUnit, are you open to a PR to back port attribute mechanism to the 2.5 branch ?

@jakzal
Copy link
Owner

jakzal commented Apr 2, 2023

We would need to release 2.6 I guess.

Is it really not trivial to migrate PHPUnit? What are the main blockers? Is it the new event system?

If this is really what people want/need and you're happy to do the work (which we will release as 2.6), then I have nothing against it. As on 3.x we'd need to deprecate annotations on 2.6 though.

Sorry, I thought I'd just be doing bug fixes on 2.5 at this point, so I'd like to make sure I'm not going to bring whole lot of maintenance burden first 😂

@jdecool
Copy link
Author

jdecool commented Apr 2, 2023

Is it really not trivial to migrate PHPUnit?

Big code base can be hard to migrate.

The main pain point I've encountered is about data providers that are becoming static.
But some code contains a lot of reference to $this

@jakzal
Copy link
Owner

jakzal commented Apr 4, 2023

Released as v2.6.0.

@jakzal jakzal closed this as completed Apr 4, 2023
@jdecool
Copy link
Author

jdecool commented Apr 4, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants