Add new feat to deal with invalid pkg name

jalal246 · Apr 13, 2020 · 12c0c80 · 12c0c80
1 parent 3664d9c
commit 12c0c80
Show file tree

Hide file tree

Showing 16 changed files with 323 additions and 266 deletions.
diff --git a/src/store/StateHandler.js b/src/store/StateHandler.js
@@ -1,5 +1,5 @@
 /* eslint-disable no-nested-ternary */
-import { resolve } from "path";
+import { resolve, basename } from "path";
 import { validateAccess } from "validate-access";
 import { CAMEL_CASE, OUTPUT, ENTRIES, ALIAS } from "../constants";
 
@@ -17,7 +17,7 @@ class StateHandler extends State {
   extractName() {
     const outputOpt = this.opts[OUTPUT];
 
-    const chosen = outputOpt || this.pkgName;
+    const chosen = outputOpt || this.pkgName || basename(this.pkgPath);
 
     return this.opts[CAMEL_CASE] ? camelizeOutputBuild(chosen) : chosen;
   }

diff --git a/test/__snapshots__/production.test.js.snap b/test/__snapshots__/production.test.js.snap
diff --git a/test/production.test.js b/test/production.test.js
@@ -8,34 +8,39 @@ jest.setTimeout(30000);
 
 // ["basic-multi-entries-json", "pure", "alias"];
 describe("builderz working for single package", () => {
-  it.each(["basic-multi-entries-json", "pure", "alias"])(
-    "%s",
-    async (pkgName) => {
-      const pathPure = resolve(__dirname, "samples", pkgName);
-      const distPath = resolve(pathPure, "dist");
+  it.each([
+    // "basic-multi-entries-json",
+    // "pure",
+    // "alias",
+    // "basic-json",
+    // "shebang",
+    // "pretty",
+    "no-pkg-name",
+  ])("%s", async (pkgName) => {
+    const pathPure = resolve(__dirname, "samples", pkgName);
+    const distPath = resolve(pathPure, "dist");
 
-      try {
-        await builderz({
-          cleanBuild: true,
-          pkgPaths: [resolve(__dirname, pathPure)],
-        });
+    try {
+      await builderz({
+        cleanBuild: true,
+        pkgPaths: [resolve(__dirname, pathPure)],
+      });
 
-        const files = readdirSync(distPath);
-        expect(files.length).toMatchSnapshot();
+      const files = readdirSync(distPath);
+      expect(files.length).toMatchSnapshot();
 
-        files
-          .filter((file) => !/\.map$/.test(file))
-          .sort((file) => (/modern/.test(file) ? 1 : 0))
-          .forEach((file) => {
-            expect(
-              readFileSync(resolve(distPath, file)).toString("utf8")
-            ).toMatchSnapshot();
-          });
+      files
+        .filter((file) => !/\.map$/.test(file))
+        .sort((file) => (/modern/.test(file) ? 1 : 0))
+        .forEach((file) => {
+          expect(
+            readFileSync(resolve(distPath, file)).toString("utf8")
+          ).toMatchSnapshot();
+        });
 
-        // await del(distPath);
-      } catch (err) {
-        console.error(err);
-      }
+      // await del(distPath);
+    } catch (err) {
+      console.error(err);
     }
-  );
+  });
 });
diff --git a/test/samples/packages-valid/folo-forms/package.json b/test/samples/packages-valid/folo-forms/package.json
diff --git a/test/samples/packages-valid/folo-forms/src/index.js b/test/samples/packages-valid/folo-forms/src/index.js
diff --git a/test/samples/packages-valid/folo-layout/package.json b/test/samples/packages-valid/folo-layout/package.json
diff --git a/test/samples/packages-valid/folo-layout/src/index.js b/test/samples/packages-valid/folo-layout/src/index.js
diff --git a/test/samples/packages-valid/folo-utils/package.json b/test/samples/packages-valid/folo-utils/package.json
diff --git a/test/samples/packages-valid/folo-utils/src/index.js b/test/samples/packages-valid/folo-utils/src/index.js
diff --git a/test/samples/packages-valid/folo-values/package.json b/test/samples/packages-valid/folo-values/package.json
diff --git a/test/samples/packages-valid/folo-values/src/index.js b/test/samples/packages-valid/folo-values/src/index.js
diff --git a/test/samples/packages-valid/folo-withcontext/package.json b/test/samples/packages-valid/folo-withcontext/package.json
diff --git a/test/samples/packages-valid/folo-withcontext/src/index.js b/test/samples/packages-valid/folo-withcontext/src/index.js
diff --git a/test/samples/pretty/package.json b/test/samples/pretty/package.json
@@ -1,3 +1,10 @@
 {
-  "name": "pretty"
+  "name": "pretty",
+  "builderz": {
+    "formats": [
+      "cjs"
+    ],
+    "sourcemap": false,
+    "banner": "#!/usr/bin/env node"
+  }
 }
diff --git a/test/samples/shebang/package.json b/test/samples/shebang/package.json
@@ -1,3 +1,10 @@
 {
-  "name": "shebang"
+  "name": "shebang",
+  "builderz": {
+    "formats": [
+      "cjs"
+    ],
+    "sourcemap": false,
+    "banner": "#!/usr/bin/env node"
+  }
 }
diff --git a/test/samples/shebang/src/index.js b/test/samples/shebang/src/index.js
@@ -1,5 +1,3 @@
-#!/usr/bin/env node
-
 export function foo() {
-	return 'hello world';
+  return "hello world";
 }