feat: Add support for logging via DataDog #88

chimedpalden · 2023-12-15T07:47:01Z

Description

This PR Adds the Datadog logger. I'll be removing all other logger once the Datadog integration is tested successfully on preview and on production.

#87

bbbneo333

Please fix typos.

Also, from ticket, is this requirement being fulfilled?

A log should have clear details on environment (staging, production, etc..)

If yes - Can post example of a screenshot where it has the environment?

bbbneo333 · 2023-12-18T09:25:03Z

src/apps/backend/modules/logger/internals/datadog-logger.ts

+
+import WinstonLogger from './winston-logger';
+
+export default class DatedogLogger extends WinstonLogger {


typo - DatedogLogger

bbbneo333 · 2023-12-18T09:25:18Z

src/apps/backend/modules/logger/internals/loggers.ts

@@ -2,6 +2,7 @@ import ConfigService from '../../config/config-service';
 import { UnknownTransportError } from '../types';

 import ConsoleLogger from './console-logger';
+import DatedogLogger from './datadog-logger';


typo - DatedogLogger

jalan-technologies-sonarqube · 2023-12-18T10:45:44Z

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

No coverage information (0.00% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: jalantechnologies_boilerplate-mern

View in SonarQube

github-actions · 2023-12-18T10:47:06Z

Deployment (boilerplate-mern) is available at - https://912c72aad493c7a.preview.platform.jalantechnologies.com

github-actions · 2023-12-18T10:48:11Z

Package	Line Rate	Branch Rate	Health
backend	96%	50%	✔
backend.modules.access-token	100%	100%	✔
backend.modules.access-token.internal	100%	100%	✔
backend.modules.access-token.rest-api	98%	100%	✔
backend.modules.account	77%	100%	➖
backend.modules.account.internal	94%	67%	✔
backend.modules.account.internal.store	92%	50%	✔
backend.modules.account.rest-api	100%	100%	✔
backend.modules.communication	83%	75%	✔
backend.modules.communication.internals	90%	56%	✔
backend.modules.config	92%	88%	✔
backend.modules.error	81%	50%	✔
backend.modules.logger	78%	100%	➖
backend.modules.logger.internals	65%	42%	➖
backend.modules.task	90%	100%	✔
backend.modules.task.internal	95%	60%	✔
backend.modules.task.internal.store	92%	50%	✔
backend.modules.task.rest-api	94%	100%	✔
Summary	88% (553 / 632)	66% (60 / 91)	✔

Minimum allowed line rate is 60%

chimedpalden · 2023-12-18T10:48:24Z

Please fix typos.

Also, from ticket, is this requirement being fulfilled?
A log should have clear details on environment (staging, production, etc..)
If yes - Can post example of a screenshot where it has the environment?

@bbbneo333 fixed the typo. The environment can be determined by the service name for eg: boilerplate-mern-preview or boilerplate-mern-production.

jjalan · 2023-12-18T11:01:22Z

src/apps/backend/modules/logger/internals/types.ts

@@ -15,4 +15,5 @@ export enum LoggerTransport {
  Rollbar = 'rollbar',
  Grafana = 'grafana',
  Papertrail = 'papertrail',
+  Datadog = 'datadog',


Should we remove support for all other logger types such as Rollbar, Grafana, Papertrail etc to reflect one opiniated approach on monitoring / logging from boilerplate standpoint or would that be part of separate PR?

yes, @jjalan i'll remove it in a separate PR. I just wanted to test the end-to-end flow from logging to alert in the MS team via datadog in preview env before removing other options.

bbbneo333 · 2023-12-18T12:31:32Z

LGTM!
@chimedpalden - Please make sure appropriate env vars are already set in doppler before merging the PR.

chimedpalden self-assigned this Dec 15, 2023

chimedpalden added the enhancement New feature or request label Dec 15, 2023