Ignoring decimal places parameters.

[BillYovino]

Platform

Raspberry Pi OS Bullseye 64

Node.js Version

16.20.0

MagicMirror Version

2.23

Module Version

v2.80

Description

The module is ignoring the config values for numberDecimalsPercentages and numberDecimalsValues
Regardless of the settings, the stock values and change percentages are showing 3 decimal places.

Expected behavior

I would expect AMZN to show as 124..86 (-0.93) and UA as 6.83 (-0.10)

Current behavior

AMZN shows as 124..855 (-0.925) and UA as 6.825 (-0.0985)

Possible solution

I believe the module is ignoring the config values and defaults for those attributes.

Steps to reproduce

The issue is constant and repeatable.

Log

No errors, just incorrect formatting

config.js

{
	module: "MMM-Jast",
	position: "bottom_bar",
	config: {
		currencyStyle: "code", // One of ["code", "symbol", "name"]
		fadeSpeedInSeconds: 100,
		lastUpdateFormat: "HH:mm",
		maxChangeAge: 1 * 24 * 60 * 60 * 1000,
		maxWidth: "100%",
		numberDecimalsPercentages: 1,
		numberDecimalsValues: 2,
		scroll: "horizontal", // One of ["none", "vertical", "horizontal"]
		showColors: true,
		showCurrency: false,
		showChangePercent: false,
		showChangeValue: true,
		showChangeValueCurrency: false,
		showHiddenStocks: false,
		showLastUpdate: false,
		showPortfolioValue: false,
		showPortfolioGrowthPercent: false,
		showPortfolioGrowth: false,
		updateIntervalInSeconds: 300,
		useGrouping: false,
		virtualHorizontalMultiplier: 2,
		stocks: [
			{ name: "DJI", symbol: "^DJI"},
			{ name: "NASD", symbol: "^IXIC"},
			{ name: "AAPL", symbol: "AAPL" },
			{ name: "GOOG", symbol: "GOOG"},
                        { name: "AMZN", symbol: "AMZN"},
                        { name: "META", symbol: "META"},
                        { name: "TSLA", symbol: "TSLA"},
                        { name: "UA", symbol: "UA"}
		]
	}
}

Additional info

No response

[jalibu]

Hi @BillYovino ,

thank you for reporting this.

I can reproduce your finding. I'll try to fix it asap

[jalibu]

Should be fixed with https://github.com/jalibu/MMM-Jast/releases/tag/v2.8.2

[BillYovino]

Thanks! That was quick. Do I git clone the repository again or is there another way to update it?

…

On Sat, Jul 15, 2023 at 5:26 AM Jan ***@***.***> wrote: Hi @BillYovino <https://github.com/BillYovino> , thank you for reporting this. I can reproduce your finding. I'll try to fix it asap — Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN74QUVKKS5W7NZD6TIVOBLXQJO4RANCNFSM6AAAAAAZPCQ5NQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>