Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend known failure files #1

Conversation

stefanobaghino
Copy link

I'm not 100% sure this is the solution you are looking for, but given the change you are making it seems relatively sensible that the status of a few tests might have changed. Just submitting for your feedback, do let me know if this is not the right path to go down to. In practice, this makes make assets, make syntest, and make syntest-fancy pass (at least locally, but I don't see reasons why this should be different on CI).

Readme.md Outdated
@@ -242,6 +242,7 @@ Below is a list of projects using Syntect, in approximate order by how long they
- [The Way](https://github.com/out-of-cheese-error/the-way), a code snippets manager for your terminal that uses `syntect`for highlighting.
- [Broot](https://github.com/Canop/broot), a terminal file manager, uses `syntect` for file previews.
- [Rusty Slider](https://ollej.github.io/rusty-slider/), a markdown slideshow presentation application, uses `syntect` for code blocks.
- [BugStalker](https://github.com/godzie44/BugStalker/), modern debugger for Linux x86-64. Written in Rust for Rust programs.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resulted from merging with the upstream master branch to avoid drifting away.

@jalil-salame
Copy link
Owner

Thanks for the PR and taking a look at it, I rebased on top of master manually c:

@stefanobaghino stefanobaghino deleted the stefanobaghino/535-change-known-failures branch May 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants