Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statsd integration + Tomcat redeploy fix for PeriodicalLog #19

Merged
merged 2 commits into from Jul 23, 2012

Conversation

pcting
Copy link
Contributor

@pcting pcting commented Mar 9, 2012

Two things in this pull request:

  • I added a StatsdLog which will allow speed4j to emit statsd metrics
  • c_factories is set to null at the end of StopWatchFactory.shutdown() so that Tomcat can redeploy the application and also reinitialize speed4j in the process.

@jalkanen
Copy link
Owner

Yah, I think that just adding the license would be sufficient. Thanks!

@mailsurfie
Copy link

is this feature included in the trunk source? and should this issue be closed?

@pcting
Copy link
Contributor Author

pcting commented May 31, 2012

no, i've been lazy about reformatting the code to be accepted. i'll try to spend time on it; it'll probably only be an hour's worth of work.

@pcting
Copy link
Contributor Author

pcting commented Jul 18, 2012

i finally got around to pinging the statsd guys:
statsd/statsd#122

we'll know whether we can use the code soon

@mrtazz
Copy link

mrtazz commented Jul 18, 2012

Isn't the MIT license compatible with the ASL? From what I've read so far, it should be ok to use it within the project. Or is that a specific project restriction?

@pcting
Copy link
Contributor Author

pcting commented Jul 18, 2012

@jalkanen will you be okay if i tacked on the MIT license instead of ASL for just the StatsdClient.java file?

@jalkanen
Copy link
Owner

MIT license is fine!

Added DoubleSetter to be able to parse doubles in the speed4j.properties file.
@pcting
Copy link
Contributor Author

pcting commented Jul 23, 2012

@jalkanen I adjusted the commits to fit the coding style and added the MIT license to the top of the StatsdClient class.

jalkanen added a commit that referenced this pull request Jul 23, 2012
Statsd integration + Tomcat redeploy fix for PeriodicalLog
@jalkanen jalkanen merged commit 68f7a75 into jalkanen:master Jul 23, 2012
@jalkanen
Copy link
Owner

Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants