Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate how to avoid the cursor resetting to the beginning of an expression when the MathInput component re-renders #17

Closed
jaltekruse opened this issue Jan 5, 2018 · 2 comments
Closed

Investigate how to avoid the cursor resetting to the beginning of an expression when the MathInput component re-renders #17

jaltekruse opened this issue Jan 5, 2018 · 2 comments

Comments

@jaltekruse
Copy link
Owner

I am currently working around this by no re-rendering the expressions. This caused problem when I tried to implement deleting and adding individual steps anywhere in the list. In this case I cannot use the index in the list as the React DOM element key.
@jaltekruse jaltekruse mentioned this issue Jan 5, 2018
Closed
@jaltekruse
Copy link
Owner Author

Fixed on the branch for deleting a step, it also adds fancier undo/redo, need to add more tests and merge this into master.

@jaltekruse
Copy link
Owner Author

This has been fixed and merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaltekruse