Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

[BUG]Turn marker appears before combat is started or initiative is rolled #11

Open
delVhariant opened this issue Jul 6, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@delVhariant
Copy link

Describe the bug
When creating an encounter, the turn marker is added to the first Actor in the encounter list, even if the Encounter has not been started, and initiative has not yet been rolled.

This makes it difficult to "pre-set" encounters, as the players may be able to see the turn marker through walls.

Environment Details
Foundry VTT Version: 0.6.4
Turn Marker Version: 2.6.9

To Reproduce
1: Add some Actors to a new encounter
2: The turn marker appears on the first actor in the encounter list

Expected behavior
Turn marker should not appear until the GM clicks "Begin Encounter"

@kckaiwei
Copy link
Contributor

@delVhariant If you're still following this issue, I've taken over the repo on FoundryVTT and have my github repo here:

https://github.com/kckaiwei/TurnMarker-alt

I believe I've solved the issue described, but since it's tied to updateCombat which seems to fire semi-randomly sometimes, following the reproduction steps does not actually fire updateCombat sometimes. However, I'm pretty confident it's fixed now, since I haven't been able to reproduce it, and creating the turn marker now checks if combat.started is true.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants