Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Styled target and style public #56

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

davidkna
Copy link
Contributor

This allows easily accessing and unstyled version of a Styled and allows amending a Style later on.

Copy link
Owner

@jam1garner jam1garner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making both fields public limits the possibility of future changes. I think these would be better as methods? alternatively the struct would need to be #[non_exhaustive].

@davidkna
Copy link
Contributor Author

@jam1garner All the Style methods require full ownership, so I felt that exposing style completely makes sense. I will work on exposing the target with methods instead and keep style public.

@jam1garner jam1garner merged commit 15d30f5 into jam1garner:master Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants