Delete "no unsafe" claim from readme #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"No unsafe" is misleading because there is unsafe code unconditionally compiled into the crate. It looks like this sentence in the readme was written in 408f42a and "no unsafe" was true at that point, but then 48 hours later some unsafe code was added in 8904b5e and has been there ever since. It seems like an oversight that the readme was not updated.
|
heh, fair, that was me forgetting! retroactive justification: I'd definitely argue that const-time unsafe doesn't break the spirit of it, but given I don't particularly mind dropping the claim, I'll give you it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"No unsafe" is misleading because there is unsafe code unconditionally compiled into the crate.
It looks like this sentence in the readme was written in 408f42a and "no unsafe" was true at that point, but then 48 hours later some unsafe code was added in 8904b5e and has been there ever since. It seems like an oversight that the readme was not updated.