Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature separation of supports-colors #90

Closed

Conversation

indietyp
Copy link
Contributor

@indietyp indietyp commented Jan 19, 2023

Implements #88.

This separates the supports-colors feature into three different features:

  • supports-colors
  • std
  • override

The override methods (and if_supports_color) are now enabled with the override feature.

This also "fixes" #82 by introducing a new Stream type, essentially the same as supports-colors, but needs to be implemented as a new type as it is exposed when the override feature is enabled. (a From implementation is provided).

This also makes all tests no-std compatible by introducing a new helper: assert_str.

(all permutations also have been tested using cargo hack test --feature-powerset)

@jam1garner
Copy link
Owner

Very sorry for letting this grow stale, I've been locked out of github for a while and only really been able to push commits. I'd really hate to ask you to redo the work to be compatible with #115 so I think I'll just close this and I'll try and see if I find the time to redo the work myself before pushing 4.0

@jam1garner jam1garner closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants