added Ukrainian locale #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jama5262
requested changes
Apr 20, 2021
There was a problem hiding this comment.
Please make sure you've added the locale to the docs here https://github.com/jama5262/jiffy/tree/v4.1.0/doc#locale-support
And make sure you format your code so that the tests can pass, try running this command
flutter format lib test
Codecov Report
@@ Coverage Diff @@
## develop #113 +/- ##
===========================================
- Coverage 93.93% 93.28% -0.65%
===========================================
Files 29 30 +1
Lines 1187 1236 +49
===========================================
+ Hits 1115 1153 +38
- Misses 72 83 +11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jama5262
Firstly I'd like to thank you for the great tool!
I added Ukrainian locale