Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dutch language support #114

Merged
merged 4 commits into from May 3, 2021
Merged

Add dutch language support #114

merged 4 commits into from May 3, 2021

Conversation

diegonuja
Copy link

@diegonuja diegonuja commented Apr 28, 2021

Hi,

I'd like to add support for Dutch.

Thanks!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change)

Checklist

  • Directed the PR to develop branch and not the master branch
  • Wrote additional tests, if needed
  • All tests have passed
  • I have updated the documentation accordingly, if needed.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #114 (6f49fcb) into develop (35dab1e) will decrease coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #114      +/-   ##
===========================================
- Coverage    93.93%   93.44%   -0.50%     
===========================================
  Files           29       31       +2     
  Lines         1187     1266      +79     
===========================================
+ Hits          1115     1183      +68     
- Misses          72       83      +11     
Impacted Files Coverage Δ
lib/src/locale/availableLocales.dart 98.18% <100.00%> (+0.06%) ⬆️
lib/src/locale/nlLocale.dart 100.00% <100.00%> (ø)
lib/src/locale/ukLocale.dart 77.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35dab1e...6f49fcb. Read the comment docs.

Copy link
Owner

@jama5262 jama5262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you've added the nl in the docs here https://github.com/jama5262/jiffy/tree/v4.1.0/doc#locale-support

@jama5262 jama5262 merged commit bb9e959 into jama5262:develop May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants