Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add km_kh locale" #238

Merged
merged 2 commits into from Jun 2, 2023
Merged

Revert "Add km_kh locale" #238

merged 2 commits into from Jun 2, 2023

Conversation

jama5262
Copy link
Owner

@jama5262 jama5262 commented Jun 2, 2023

@Kuntheasoung reverting your changes due to tests failing

Theses are the changes from #234, please fix you tests for adding the km_kh locale

You can always reopen a new PR by reverting the changes of this PR, the button to revert the changes is below

Once reverted make sure the dart format and tests are working. You can check them by using

If in Windows run the following in the terminal

  • .\bin\dart_analyze.bat to analyze dart code
  • .\bin\dart_format.bat to format dart code
  • .\bin\dart_test.bat to run test and make sure they pass

If in Linux or Mac

  • .\bin\dart_analyze.sh to analyze dart code
  • .\bin\dart_format.sh to format dart code
  • .\bin\dart_test.sh to run test and make sure they pass

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (657603c) 96.32% compared to head (beac4d3) 96.32%.

❗ Current head beac4d3 differs from pull request most recent head 84e052a. Consider uploading reports for the commit 84e052a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          34       34           
  Lines        1550     1550           
=======================================
  Hits         1493     1493           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jama5262 jama5262 merged commit 3593a29 into master Jun 2, 2023
3 checks passed
@jama5262 jama5262 deleted the revert-234-master branch June 2, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant