Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh_locale.dart #263

Merged
merged 3 commits into from Mar 26, 2024
Merged

Update zh_locale.dart #263

merged 3 commits into from Mar 26, 2024

Conversation

BenderBlog
Copy link
Contributor

What does this PR do?

Per Unicode CLDR, in mainland China, Monday is the first day of the week.
For Hong Kong SAR, Macau SAR, and Taiwan, Sunday is the first day of the week, per Unicode CLDR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance change (non-breaking change such as upgrading a dependency, refactoring, or making a lint fix)
  • Documentation update
  • Breaking change (a fix or feature that would cause existing functionality to change)

Checklist

  • Wrote additional tests, if needed
  • All tests have passed, you can find the scripts from the ./bin folder
  • I have updated the documentation accordingly, if needed.

Additional Information

Check https://www.unicode.org/cldr/charts/44/supplemental/territory_information.html and search for China, and you will get my idea.

Copy link
Owner

@jama5262 jama5262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I have also updated the test

@jama5262 jama5262 merged commit 66cc0a7 into jama5262:master Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants