Add Bahasa Indonesia (Indonesian) locale language #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jama5262
requested changes
Jan 16, 2020
There was a problem hiding this comment.
I will request a change to edit the id from lib/src/utils/ordinalLocale.dart in line 3 plus the id string pushes the other locales out of their place hence the whole file has bugs.
To fix this move it to the bottom, that is under dech local and add its own ordinal string formats like the others, if Indonesia does not have an ordinal date, just make them empty strings, like so
localeOrdinals[18]: ["", "", "", ""],
jama5262
requested changes
Jan 16, 2020
jama5262
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am adding support for Bahasa Indonesia (Indonesian Language).
Thank you