Change queryCollection request payload and response parsing

[wsykala]

#350

This change works for table views, but it might not work for other types (for example board view).

[pavelapekhtin]

Did not seem to fix it for me, or am i doing it wrong?

merging it like this
pip install git+https://github.com/jamalex/notion-py.git@refs/pull/352/merge

and it fails at get_rows() with raise HTTPError( requests.exceptions.HTTPError: Invalid input.

client = NotionClient(token_v2=v2_token)
page = client.get_block(page_url)
cv = client.get_collection_view(page_url)

for row in cv.collection.get_rows(search='Q'):
....

[guillaumefrd]

Thanks, it worked for my table view!

[wsykala]

The issue is that the request payload for queryCollection endpoint changed and it looks like it has different structure depending on the type of collection you are trying to get rows from. Below is an example from the collection that I am getting using my scripts:

{
  "collection":{
    "id":"collection-id",
    "spaceId":"space-id"
  },
  "collectionView":{
    "id":"collection-view-id",
    "spaceId":"space-id"
  },
  "loader":{
    "type":"reducer",
    "reducers":{
      "collection_group_results":{
        "type":"results",
        "limit":"limit"
      },
      # This looks to be optional and it takes the aggregates
      # No idea how the name is generated though
      "table:uncategorized:title:count":{}
    },
    "sort":[],
    "searchQuery":"",
    "userTimeZone":""
  }
}

I will take a look later and try to make it work for other types, but it might be hard.

@pavelapekhtin Could you try to run get_rows() without any arguments and see if it works?

[pavelapekhtin]

@wsykala same story unfortunately

tried it also outside for loop too

[felipehlvo]

It also worked in my board view!

[arturmesquitab]

Thanks, works for me as well!

[wsykala]

Might fix some of the issues mentioned in #351

[infraredgirl]

Looks good and confirm it fixes the issue!

[alexattia]

Working for me! Would be great if it could be merged

[thomashirtz]

When will it be merged ? It is quite annoying to have buggy notion-py out of the box ..

[ashutoshsaboo]

+1, can you please merge these changes @wsykala given now the PR has been approved as well by both reviewers?

[wsykala]

@ashutoshsaboo I would love to do it but I don't have write access to the main repository so I can't merge it

[ashutoshsaboo]

cc'ing repo owner, @jamalex could you please help get this PR merged? notion-py seems to be broken rn without this fix..

[srepollock]

Is there a timeline for when this will be merged in?

[wsykala]

Updated to address #365 (comment)

[laserroger]

Hi, under this case how can we use filters in cv.build_query()?
I checked that in store.py, call_query_collection, the filter is not used in the data.

[laserroger]

Now I can only do the filtering via the "integration" method suggested by the notion official API. The v2 token doesn't work for this method even after formatting the filter properly and embedding it into the store.py's data in the call_query_collection .

[jamalex]

Thanks all, and sorry that I haven't been able to attend to this project due to capacity. Trying to get some of the key PRs like this merged in now to get the base version functional again.