Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last Login should only be set if user logs in #25

Closed
jambonrose opened this issue Aug 15, 2017 · 1 comment
Closed

Last Login should only be set if user logs in #25

jambonrose opened this issue Aug 15, 2017 · 1 comment
Projects
Version 1.0

Comments

@jambonrose
Copy link
Contributor

The UserManager currently sets both date_joined and last_login to the current date. Later Django versions make it so that last_login is only set if the user has actually logged in.

We ostensibly have a test for this in test_models.py. Some exploration for what is going on here is required.

Thanks to @jschneier for reporting this at DjangoCon US 2017.
@jambonrose jambonrose added this to To Do in Version 1.0 Aug 15, 2017
@jambonrose
Copy link
Contributor Author

We have the desired behavior when using create(), but not when using create_user. 😓

jambonrose added a commit that referenced this issue Aug 18, 2017
@jambonrose
Fix #25 - User Manager doesn't set last_login
ecebec9 
Thanks to @jschneier for reporting the issue.
@jambonrose jambonrose moved this from To Do to Done in Version 1.0 Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Version 1.0
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jambonrose