Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user registration without short name #23

Merged
merged 4 commits into from Aug 15, 2017

Conversation

jambonrose
Copy link
Contributor

Following discussions at DjangoCon US 2017, this PR will make it so that both full_name and short_name have blank=True, making it so that Users can (by default) register to sites using only emailand password.

The rationale is that making the field required in a custom form is easier than removing the requirement (blank=False) from the model.

This PR also modifies the test runner to check that the migration file(s) is(are) in sync with the user model.

@codecov
Copy link

codecov bot commented Aug 15, 2017

Codecov Report

Merging #23 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           development    #23   +/-   ##
==========================================
  Coverage          100%   100%           
==========================================
  Files                7      7           
  Lines              171    171           
  Branches            11     11           
==========================================
  Hits               171    171
Impacted Files Coverage Δ
src/improved_user/migrations/0001_initial.py 100% <ø> (ø) ⬆️
src/improved_user/models.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935a3c7...cc89b34. Read the comment docs.

@jambonrose jambonrose merged commit 11287e9 into development Aug 15, 2017
@jambonrose jambonrose deleted the allow_user_registration_without_short_name branch August 15, 2017 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant