Enable UserAttributeSimilarityValidator to be used with SimpleUser #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Last @freakboy3742 and I spoke about this PR, we opted to wait until there was public approval for the method I used to get the The code used here has been accepted in django/django#8408, and I am therefore merging this code (after a few minor tweaks). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.9 introduced the UserAttributeSimilarityValidator. While we use the validators, we weren't actually plugging into the UserAttributeSimilarityValidator. The
instanceof the UserCreateForm doesn't actually exist, and we were assigning a value tousername, which no longer exists.This changes the form to use the
_post_cleanhook ofModelFormto run the password validation scheme after the creation of the User instance.This PR also changes the travis file to run tests on more recent versions of Python and Django.