Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/background listen tag #391

Merged
merged 3 commits into from Jul 11, 2023
Merged

Fix/background listen tag #391

merged 3 commits into from Jul 11, 2023

Conversation

xquanluu
Copy link
Contributor

@xquanluu xquanluu commented Jul 10, 2023

Fix Feature server don't send customerData to api-server for record all call feature

@javibookline
Copy link
Contributor

Hi @xquanluu have you been able to review the comment I added??

That the code in call-session.js

// Remove unneeded customer data to be sent to api server.
this.backgroundGatherTask.ignoreCustomerData = true;

should be

// Remove unneeded customer data to be sent to api server.
this.backgroundListenTask.ignoreCustomerData = true;

@xquanluu xquanluu marked this pull request as ready for review July 11, 2023 14:31
@xquanluu
Copy link
Contributor Author

Thanks a lot @javibookline to point that out.
I have fixed the issue by your comment, now all testcases are passed.

@davehorton davehorton merged commit e1dad56 into main Jul 11, 2023
3 checks passed
@davehorton davehorton deleted the fix/background-listen-tag branch July 11, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants