Feature/episode groups #20
Conversation
| var sanitizedGroupName = tvGroup.Name.Trim().ToLower(); | ||
| int? seasonNumber = null; | ||
|
|
||
| var seasonMatch = EpisodeRegex().Match(sanitizedGroupName); |
There was a problem hiding this comment.
I'm not sure how reliable it will be to do the parsing this way, but is there really an alternative? This breaks in some cases (e.g. Season 04 Part 1 and 2 for this due to the duplicate season 4). It also breaks for any episode groups that aren't in English of course.
I don't think much can be done about this though, the subgroups don't have a set numerical season number so it all just depends on how the subgroups are named.
I'm not sure how common this is for episode groups on TMDB, I guess it would be fine to just add a disclaimer that it may not work in every case.
Handle cases where shows do not have any episode groups Fix chosen episode group not being selected Fix error when finding cover filename Increment config version
|
Thanks for the pull request, apologies for the delay in reviewing it. This is a bit of a complicated feature that I had considered in the past, but just couldn't be bothered to implement 😆. Props for doing it for me! Just fixed a few minor bugs found during testing, I think I'm happy for it to be merged if you're happy with the episode group parsing caveats mentioned in a previous comment? It would probably be a good idea to handle errors with duplicate seasons more gracefully if possible, currently it throws an exception due to the duplicate dictionary key. |
|
Thanks for looking into it! Yes you are right, the error handling could be better. I’ll get to it, as soon as i have time ;) |
I recently came across the issue, that the standard TMDB episode order for a particular show was not matching the DVD/Bluray release one. Fortunately in many cases, there are additional "Episode Groups" available, that contain custom orders and can be accessed by via TMDBs API.
To resolve my issue, I added a new flag called "--episode-group" or short "-g". When this flag is enabled, the app first behaves like if the "--manual" flag was set - the user is asked for the right tv show. After that, a second dialog is started where the user can select the wanted episode group.
Next a mapping dictionary is created, to be able to fetch the right episode information with the groups numbers, e.g. 1x47 in an episode group is equivalent to 2x03 in TMDB's standard order. For this to work, the groups within the episode group have to have a parsable name like "Season 1" , "Volume 1" or Special (which is handles as Season 0).
I tried to work with the existing code and only modify the management of the episode numbers for the API lookups.
Changelog:
Updated
Added
Changed