Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of version 2.1.0 #379

Closed
nerdbeere opened this issue Sep 19, 2018 · 12 comments
Closed

Release of version 2.1.0 #379

nerdbeere opened this issue Sep 19, 2018 · 12 comments
Labels

Comments

@nerdbeere
Copy link
Member

I'd like to release a new version once we merged james-proxy/james-browser-launcher#74 and created a new james-browser-launcher version.

How do you guys feel about this? @mitchhentges @tomitm @jrmykolyn

@mitchhentges
Copy link
Member

I remember there being some issues with electron-updater, so I'd want to ensure that we test upgrades from:

  • 2.0.0 -> 2.1.0
  • 2.1.0 -> (dummy future version)

Other than that, this sounds awesome so that that crash issue is mitigated 👍

@jrmykolyn
Copy link
Member

Thanks to everyone for bringing me on board as org. member and collaborator.

I haven't been on the team long enough to speak to the electron-related issues that @mitchhentges is referencing (although I've seen them mentioned in other PRs), but, on a personal note, I'd be happy the crash fix go out into the wild.

@nerdbeere
Copy link
Member Author

@mitchhentges not sure if I know how exactly ensure/test this properly

@mitchhentges
Copy link
Member

This was one of the problems 🤔

I'm a little fuzzy now, but there should be docs that explain enough for us to be able to test updates without actually updating real installations in the field (perhaps these?)
When I've got time (tomorrow probably) I want to do a pass at updating all of James' dependencies, including electron-*. When I do that, I'll peek through the electron-updater changelog and see what I can find

@tomitm
Copy link
Contributor

tomitm commented Sep 21, 2018

Regarding the auto-update issues @mitchhentges is talking about: I don't entirely remember the details, but #358 has some details about rolling back electron-updater to fix a Windows issue.

Looking at electron-updater's changelog, there's been a number of updates since, so it might be safe to update that dependency at this point.

I noted in the 2.0.0 release issue (#355) that auto-update is confirmed to work albeit a bit rough around the edges (otherwise I would've held off), so releasing shouldn't be an issue. :shipit:

@mitchhentges
Copy link
Member

We have changed the version of electron-updater since 2.0.0 (to 2.19.0 from 2.16.3), so we'll either want to:

  • Update electron-updater some more, and re-test updating
  • Downgrade to 2.16.3 so we can deploy 2.1.0 without fear of breakage

@mitchhentges
Copy link
Member

Dependencies have been updated as part of #387, and I'm happy with the bugfixes and perf improvements. I think after release testing we should be "green across the board" for release

@mitchhentges
Copy link
Member

mitchhentges commented Oct 8, 2018

Added documentation for running upgrade tests

"Passes upgrade test" checklist:

  • Windows
  • Linux
  • Mac

@mitchhentges
Copy link
Member

Having issues testing on mac - you can see the error on sentry

Could not get code signature for running application

🤔 not sure how to work around this yet

@mitchhentges
Copy link
Member

I couldn't find a nice way of working around this - @nerdbeere, would you be able to do an upgrade test on Mac? I've got docs available here 😄

@mitchhentges
Copy link
Member

I'm going to do a pre-release build via Travis, so I can get signed builds.
If those upgrade from our last pre-release (2.0.0-beta.3) then I'll consider it ready for release 😄

@mitchhentges
Copy link
Member

Release complete! Had an issue with exceptions being triggered when spooling up HTTPs, but I've released v2.1.1 to resolve that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants