Display browsers as list #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| browser.name = 'Internet Explorer'; | ||
| } else if (browser.type === 'chrome' && /SxS/.test(browser.command)) { | ||
| browser.name = 'Chrome Canary'; | ||
| } else if (browser.type === 'firefox' && /Developer Edition/i.test(browser.command)) { |
There was a problem hiding this comment.
Using browser.command might not work if the user changed their installation path, but the design still provides a fallback to the version number, so the user can differentiate between the two installations even if their names are the same.
|
Two notes on this:
|
|
Fixed the overflow issue! Although I noticed that |
Even though launch.detect includes a command property, doesn't appear that you can use it.
|
Looks like I can pass the name and version, so that's set! 🎉 @mitchhentges or @nerdbeere can you have a look and merge? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #90.
TODO: