Skip to content

Commit

Permalink
cmp should recognise a string being a negative int (inspec#3007)
Browse files Browse the repository at this point in the history
Signed-off-by: James Stocks <jstocks@chef.io>
  • Loading branch information
James Stocks committed May 2, 2018
1 parent 298ab79 commit 021129b
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/matchers/matchers.rb
Expand Up @@ -269,7 +269,7 @@
RSpec::Matchers.define :cmp do |first_expected| # rubocop:disable Metrics/BlockLength

def integer?(value)
!(value =~ /\A0+\Z|\A[1-9]\d*\Z/).nil?
!(value =~ /\A-?0+\Z|\A-?[1-9]\d*\Z/).nil?
end

def float?(value)
Expand Down
13 changes: 13 additions & 0 deletions test/integration/default/controls/cmp_matcher_spec.rb
Expand Up @@ -71,6 +71,19 @@
it { should_not cmp >= 13 }
end

describe '-12' do
it { should cmp -12 }
it { should cmp < -11 }
it { should cmp > -13 }
it { should_not cmp < -12 }
it { should_not cmp > -12 }
it { should cmp <= -12 }
it { should cmp >= -12 }
it { should cmp >= -666 }
it { should_not cmp <= -13 }
it { should_not cmp >= -11 }
end

# versions
describe '2.4.12' do
it { should cmp == '2.4.12' }
Expand Down

0 comments on commit 021129b

Please sign in to comment.