Skip to content

Commit

Permalink
remove disable-weak-memory-emulation (bevyengine#5469)
Browse files Browse the repository at this point in the history
# Objective

- Fixes bevyengine#5164
- Remove `miri-disable-weak-memory-emulation`
- Issue has been fixed in dependency
  • Loading branch information
mockersf authored and james7132 committed Oct 28, 2022
1 parent 9c49986 commit 2af1249
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,8 @@ jobs:
# https://github.com/rust-lang/miri#miri--z-flags-and-environment-variables
# -Zmiri-disable-isolation is needed because our executor uses `fastrand` which accesses system time.
# -Zmiri-permissive-provenance disables warnings against int2ptr casts (since those are used by once_cell)
# -Zmiri-disable-weak-memory-emulation works around https://github.com/bevyengine/bevy/issues/5164.
# -Zmiri-ignore-leaks is necessary because a bunch of tests don't join all threads before finishing.
MIRIFLAGS: -Zmiri-ignore-leaks -Zmiri-disable-isolation -Zmiri-permissive-provenance -Zmiri-disable-weak-memory-emulation
MIRIFLAGS: -Zmiri-ignore-leaks -Zmiri-disable-isolation -Zmiri-permissive-provenance

check-compiles:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 2af1249

Please sign in to comment.