Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove transient fields from migration task hashCode() and equals() #1674

Closed
fil512 opened this issue Jan 16, 2020 · 3 comments
Closed

remove transient fields from migration task hashCode() and equals() #1674

fil512 opened this issue Jan 16, 2020 · 3 comments

Comments

@fil512
Copy link
Collaborator

fil512 commented Jan 16, 2020

e.g. We need to remove both myIsOkayIfNeitherColumnExists and
myDeleteTargetColumnFirstIfBothExist from RenameColumnTask.hashCode() and RenameColumnTask.equals().

Only those fields directly pertinent to what's being migrated should be included in the hashCode. Flyway uses this hashCode to validate the migration hasn't been "tampered with" since it was last run.

@jamesagnew
Copy link
Collaborator

ooh good call.

I guess we should get a rush on this since it will be a nuisance to implement once 4.2.0/2020.02 are out.

@fil512
Copy link
Collaborator Author

fil512 commented Jan 25, 2020

Thanks for doing this @jaferkhan !

@fil512 fil512 closed this as completed Jan 25, 2020
@jaferkhan
Copy link
Contributor

@fil512 You're most welcome ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants