Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for definition of Rails::VERSION::MAJOR #89

Merged
merged 1 commit into from Jun 10, 2015

Conversation

staugaard
Copy link
Contributor

Some gems will declare the Rails module even without having a dependency on the rails gem.

I'm looking at you rails-dom-testing.
https://github.com/rails/rails-dom-testing/blob/master/lib/rails/dom/testing/version.rb

So you can end up with a Rails module without a VERSION constant.

Hi James!

@jamesarosen
Copy link
Contributor

Is defined?(Foo::Bar::Baz) legit across modern Rubies? If so, big +1 :)

@pschambacher
Copy link
Contributor

I think that it is legit

jamesarosen added a commit that referenced this pull request Jun 10, 2015
check for definition of Rails::VERSION::MAJOR
@jamesarosen jamesarosen merged commit 0d9ea38 into zendesk:master Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants