Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed gap to version 3.0.1 #28

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Conversation

YeLwinOo-Steve
Copy link
Contributor

Gap plugin syntax error when deploying on vercel

When using latest Layout plugin version from pub, it automatically downloads Gap dependency version 2. That makes syntax errors when deploying on vercel and deployment fails.

gap_version_error

So I changed it to latest Gap version and deployment becomes successful again.

@PITR-DEV
Copy link

image

It also appears to break Windows builds on Flutter beta, 3.13.0-0.1.pre

@chirag729
Copy link
Contributor

@jamesblasco please merge this critical PR

Copy link

@Mohamed-7018 Mohamed-7018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a necessary update

@khamalfa
Copy link

@YeLwinOo-Steve does the layout working even you change the version of gap?

@YeLwinOo-Steve
Copy link
Contributor Author

@YeLwinOo-Steve does the layout working even you change the version of gap?

Yes, when I changed gap version to 3, layout library works. Gap version 2 has errors. Layout library uses gap like this - gap: ">=2.0.0 <4.0.0". But it always downloads gap version 2 not the latest one. So, gap version 3 is necessary.

@alexrabin
Copy link

Is there a reason why this pr hasn't been merged yet?

@YeLwinOo-Steve
Copy link
Contributor Author

Is there a reason why this pr hasn't been merged yet?

Not sure but I think this repo is inactive for a while. I checked that the last commit was about 2 months ago. This gap version problem is an issue to take a good look or we have to clone it and change the version by ourselves. @jamesblasco

@alexrabin
Copy link

Yeah I already forked this repo and changed the gap version number.

If anyone needs a quick copy and paste:


layout:
    git:
      url: https://github.com/alexrabin/layout.git
      ref: main
      path: ""

@jamesblasco
Copy link
Owner

I am sorry. I have been quite busy these last months. Thank you for taking the time to put all this together 🙏🏼

@jamesblasco jamesblasco merged commit 21e3376 into jamesblasco:main Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants