-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed gap to version 3.0.1 #28
Conversation
@jamesblasco please merge this critical PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a necessary update
@YeLwinOo-Steve does the layout working even you change the version of gap? |
Yes, when I changed gap version to 3, layout library works. Gap version 2 has errors. Layout library uses gap like this - gap: ">=2.0.0 <4.0.0". But it always downloads gap version 2 not the latest one. So, gap version 3 is necessary. |
Is there a reason why this pr hasn't been merged yet? |
Not sure but I think this repo is inactive for a while. I checked that the last commit was about 2 months ago. This gap version problem is an issue to take a good look or we have to clone it and change the version by ourselves. @jamesblasco |
Yeah I already forked this repo and changed the gap version number. If anyone needs a quick copy and paste:
|
I am sorry. I have been quite busy these last months. Thank you for taking the time to put all this together 🙏🏼 |
Gap plugin syntax error when deploying on vercel
When using latest Layout plugin version from pub, it automatically downloads Gap dependency version 2. That makes syntax errors when deploying on vercel and deployment fails.
So I changed it to latest Gap version and deployment becomes successful again.