Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering: vcf_filter.py: added possibility to include a path to custom filters python file, not only a local script file #188

Closed
wants to merge 1 commit into from

Conversation

gitanoqevaporelmundoentero

vcf_filter.py: local-script argument changed to custom-filters, since now it is possible to include a path to custom filters python file

… now it is possible to include a path to custom filters python file
@sambrightman
Copy link

@martijnvermaat I think this also needs closing in its current state: needs rebasing, no tests, some typos (usage, function name) many unrelated changes in the commit.

The core idea is fine if it's cleaned up and rebased. I'm not sure if it's the "right" way to allow plugins, but if it works and someone wants it then it seems okay. Probably should maintain backwards compatibility with existing method?

@martijnvermaat
Copy link
Collaborator

Yes, should have closed this before. As @sambrightman says, the idea may be ok, but not in this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants