Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorchlightning #98

Merged
merged 136 commits into from
Nov 17, 2021
Merged

Pytorchlightning #98

merged 136 commits into from
Nov 17, 2021

Conversation

jameschapman19
Copy link
Owner

Big round of changes aimed at #69 #74 #75 #76 #77

The major change however is the switch from using the DeepWrapper class which was creating a lot of mess in the issues to using pytorch-lightning via a CCALightning Module which adds functionality as well as simplifying the codebase.

…hods into pytorchlightning

� Conflicts:
�	tutorial_notebooks/cca_zoo_mnist.ipynb
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
… by default and sumcor for lasso where valid
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #98 (7826a4b) into main (d06e913) will decrease coverage by 9.65%.
The diff coverage is 86.09%.

❗ Current head 7826a4b differs from pull request most recent head 156efc4. Consider uploading reports for the commit 156efc4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   86.94%   77.28%   -9.66%     
==========================================
  Files          35       37       +2     
  Lines        2703     2593     -110     
==========================================
- Hits         2350     2004     -346     
- Misses        353      589     +236     
Impacted Files Coverage Δ
cca_zoo/data/toy.py 17.36% <ø> (-72.99%) ⬇️
cca_zoo/deepmodels/dcca.py 96.15% <ø> (ø)
cca_zoo/deepmodels/dtcca.py 93.33% <ø> (ø)
cca_zoo/model_selection/_search.py 83.83% <ø> (+1.19%) ⬆️
cca_zoo/probabilisticmodels/vcca.py 94.11% <ø> (ø)
cca_zoo/deepmodels/trainers.py 56.31% <56.31%> (ø)
cca_zoo/deepmodels/_dcca_base.py 87.50% <66.66%> (-4.81%) ⬇️
cca_zoo/models/innerloop.py 76.66% <87.50%> (-9.17%) ⬇️
cca_zoo/deepmodels/dvcca.py 89.53% <90.90%> (ø)
cca_zoo/deepmodels/utils.py 91.66% <91.66%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06e913...156efc4. Read the comment docs.

@jameschapman19 jameschapman19 merged commit b1318ba into main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant