Merge pull request heartcombo#484 from julian7/minmax_barestring

Don't leak out minimum or maximum values when MinMax component is in use
jamescook · Mar 1, 2012 · e067d8d · e067d8d
2 parents 42c6052 + c4db622
commit e067d8d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/simple_form/components/min_max.rb b/lib/simple_form/components/min_max.rb
@@ -7,6 +7,7 @@ def min_max
           input_html_options[:min] ||= minimum_value(validator_options)
           input_html_options[:max] ||= maximum_value(validator_options)
         end
+        nil
       end
 
       private

diff --git a/test/inputs/numeric_input_test.rb b/test/inputs/numeric_input_test.rb
@@ -164,4 +164,10 @@ class NumericInputTest < ActionView::TestCase
       assert_select 'input[max=99]'
     end
   end
+
+  test 'min_max should not emit max value as bare string' do
+    with_input_for @other_validating_user, :age, :integer
+    assert_select 'div', {:count => 0, :text => %r{^99}}
+  end
+
 end