Refuse to handle exclusive slices in

jamesdabbs · Apr 11, 2013 · 3306667 · 3306667
1 parent 6fc5628
commit 3306667
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/steffi/vector.rb b/lib/steffi/vector.rb
@@ -27,7 +27,7 @@ def self.from_a ary
     end
 
     def self.from_slice slice
-      # FIXME: this only works for inclusive slices
+      raise "Slices should be inclusive" if slice.exclude_end?
       new { |v| Igraph.vector_init_seq v.pointer, slice.first, slice.last }
     end
 

diff --git a/spec/steffi/vector_spec.rb b/spec/steffi/vector_spec.rb
@@ -9,6 +9,10 @@
     Steffi::Vector.from_slice(5..9).should have(5).members
   end
 
+  it 'errors on exclusive slices' do
+    expect { Steffi::Vector.from_slice(5...9) }.to raise_error
+  end
+
   # -----
 
   subject { Steffi::Vector.from_a [2, 3, 4] }