fix: url generation handling of all types #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuunit
force-pushed
the
bugfix/url-generation
branch
from
ad6cd9e
to
af9bd39
Compare
tuunit
changed the title
jamesgeorge007
changed the title
jamesgeorge007
requested changes
Jul 7, 2023
There was a problem hiding this comment.
Could you also remove the reference to urlPrefix since it is not consumed elsewhere?
github-activity-readme/index.js
Line 24 in af9bd39
tuunit
force-pushed
the
bugfix/url-generation
branch
from
af9bd39
to
b4341f7
Compare
jamesgeorge007
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jamesgeorge007,
this is the cherry-pick of the url generation fix to properly handle all types that are currently supported including the release type introduced in version 0.4.0.
Fixes #99