Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume leading forward slash on links #5

Closed
clayrisser opened this issue Jan 8, 2018 · 10 comments
Closed

Assume leading forward slash on links #5

clayrisser opened this issue Jan 8, 2018 · 10 comments

Comments

@clayrisser
Copy link
Contributor

The fix for issue #3 only surfaces on GitHub, but nonetheless, I think was still an important fix. However, the fix assumes links start with a leading forward slash. I think the config should be updated to match this.

@clayrisser
Copy link
Contributor Author

Ok, I think the problem is deeper than github. It has to do with adding a baseurl. I'm still looking into a good way to fix this. My last pull request fixed it for a baseurl, but may have broken for sites without a baseurl.

@jameshamann
Copy link
Owner

jameshamann commented Jan 8, 2018

I think I've fixed this, could be wrong, by removing the last "/" from the url in the config.yml.

#6

Have a test and let me know if you come up with anything, I'll leave this open for a while until I hear back.

@clayrisser
Copy link
Contributor Author

Ok, I think we're on the right track. The baseurl must end with a / or it doesn't work.

@clayrisser
Copy link
Contributor Author

That doesn't make send to me though. Seems odd that the baseurl needs to end with a /.

@clayrisser
Copy link
Contributor Author

Oh, I'm sorry, I was on the wrong track about ending with a /. I imported your custom website with added the {{site.baseurl}}assets. . . back into the code.

@clayrisser
Copy link
Contributor Author

I hope you don't mind me using that code because it's not licensed.

@clayrisser
Copy link
Contributor Author

Ok, I found the solution, we need to set the baseurl to an empty string when you're not using the baseurl

@clayrisser
Copy link
Contributor Author

Or leave it empty, that works too.

clayrisser added a commit to clayrisser/jekyll-jam-theme that referenced this issue Jan 8, 2018
@clayrisser
Copy link
Contributor Author

Ah, you came to the same conclusion

@jameshamann
Copy link
Owner

Thanks for all the help, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants