Add tests for fetchData

package.json

@@ -31,8 +31,8 @@
     "sanctuary": "^0.11.1"
   },
   "devDependencies": {
-    "babel-core": "^6.21.0",
     "babel-cli": "^6.18.0",
+    "babel-core": "^6.21.0",
     "babel-plugin-transform-es2015-modules-commonjs": "^6.18.0",
     "babel-register": "^6.18.0",
     "coveralls": "^2.11.15",

src/polling/index.js

@@ -13,7 +13,7 @@ const handleResponse = chain(res => {
 
 const poll = compose(handleResponse, makeRequest());
 
-export const pollRes = (rej, res, fetchData, url, data, timeout = setTimeout) => {
+export const resolvePollRes = (rej, res, fetchData, url, data, timeout = setTimeout) => {
   if (propEq('Status', 'UpdatesComplete', data)) {
     console.log('Query result complete');
     res(data);
@@ -23,7 +23,7 @@ export const pollRes = (rej, res, fetchData, url, data, timeout = setTimeout) =>
   }
 }
 
-export const fetchData = (url, pollEndpoint = poll) =>
+export const fetchData = (url, pollEndpoint = poll, pollRes = resolvePollRes) =>
   (rej, res) => {
     pollEndpoint(url).fork(
       rej,

src/polling/index.spec.js

@@ -1,10 +1,36 @@
+import { of, reject } from 'fluture';
 import assert from 'power-assert';
 import { match, spy } from 'sinon';
 
-import { fetchData, pollRes } from './';
+import { fetchData, resolvePollRes } from './';
 
 describe('API: Polling', () => {
-  describe('pollRes', () => {
+  describe('fetchData', () => {
+    it('uses the reject branch of the parent future when necessary', () => {
+      const rej = spy();
+      const res = null;
+      const poll = () => reject('This is an error!');
+      fetchData('http://moo', poll)(rej, res);
+      assert(rej.calledWith('This is an error!'));
+    });
+
+    it('calls resolvePollRes to process poll result', () => {
+      const rej = () => {};
+      const res = () => {};
+      const poll = () => of({ some: 'data' });
+      const pollRes = spy();
+      fetchData('http://moo', poll, pollRes)(rej, res);
+      assert(pollRes.calledWith(
+        rej,
+        res,
+        fetchData,
+        'http://moo',
+        { some: 'data' }
+      ))
+    });
+  });
+
+  describe('resolvePollRes', () => {
     it('returns data once the data is ready', () => {
       const rej = spy();
       const res = spy();
@@ -13,7 +39,7 @@ describe('API: Polling', () => {
         Status: 'UpdatesComplete'
       };
 
-      const result = pollRes(rej, res, fetchData, 'url', data);
+      const result = resolvePollRes(rej, res, fetchData, 'url', data);
       assert(res.calledWith(data));
     });
 
@@ -27,7 +53,7 @@ describe('API: Polling', () => {
           Status: 'UpdatesPending'
         };
 
-        const result = pollRes(
+        const result = resolvePollRes(
           rej,
           res,
           fetchData,
@@ -49,7 +75,7 @@ describe('API: Polling', () => {
           Status: 'UpdatesPending'
         };
 
-        const result = pollRes(
+        const result = resolvePollRes(
           rej,
           res,
           fetchData,

yarn.lock

@@ -832,7 +832,7 @@ glob-parent@^2.0.0:
   dependencies:
     is-glob "^2.0.0"
 
-glob@7.0.5, glob@^7.0.5:
+glob@7.0.5:
   version "7.0.5"
   resolved "https://registry.yarnpkg.com/glob/-/glob-7.0.5.tgz#b4202a69099bbb4d292a7c1b95b6682b67ebdc95"
   dependencies:
@@ -853,7 +853,7 @@ glob@^5.0.5:
     once "^1.3.0"
     path-is-absolute "^1.0.0"
 
-glob@^7.0.6:
+glob@^7.0.5, glob@^7.0.6:
   version "7.1.1"
   resolved "https://registry.yarnpkg.com/glob/-/glob-7.1.1.tgz#805211df04faaf1c63a3600306cdf5ade50b2ec8"
   dependencies: