Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iam auth support #25

Merged
merged 14 commits into from
Apr 6, 2021
Merged

Conversation

hanswesterbeek
Copy link
Contributor

@hanswesterbeek hanswesterbeek commented Mar 3, 2021

Will fetch an IAM auth token optionally.

Assumes that the pg instance lives in the same region as the destination S3 bucket.

Please forgive my rusty JS. It's been a while.

@coveralls
Copy link

coveralls commented Mar 3, 2021

Coverage Status

Coverage increased (+0.6%) to 92.414% when pulling 2afa594 on hanswesterbeek:add-iam-auth-support into e31086b on jameshy:master.

@hanswesterbeek
Copy link
Contributor Author

Will add test(s).

Copy link
Owner

@jameshy jameshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanswesterbeek!

Thanks for the PR! 🎉
I want to test it before merging, but I don't have time right now :)
I added a few comments and will test on the weekend.

lib/handler.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
lib/iam.js Show resolved Hide resolved
hanswesterbeek and others added 2 commits March 5, 2021 13:28
Co-authored-by: James Hutchby <jameshbbb@icloud.com>
Co-authored-by: James Hutchby <jameshbbb@icloud.com>
Copy link
Owner

@jameshy jameshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great to me 👏

lib/handler.js Outdated Show resolved Hide resolved
Co-authored-by: James Hutchby <jameshbbb@icloud.com>
@hanswesterbeek
Copy link
Contributor Author

hope you can merge some time soon :)

@jameshy jameshy merged commit e9fb1ef into jameshy:master Apr 6, 2021
@jameshy
Copy link
Owner

jameshy commented Apr 6, 2021

@hanswesterbeek sorry for the delay, and thanks for the PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants