Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with instead of env #37

Closed
mitinarseny opened this issue Oct 15, 2019 · 5 comments
Closed

Use with instead of env #37

mitinarseny opened this issue Oct 15, 2019 · 5 comments
Assignees
Labels
planned 🕘 This feature is planned. version 3 Issues related to version 3 of this action.
Milestone

Comments

@mitinarseny
Copy link

Better to use jobs.<job_id>.steps.with instead of env variables as it more stable and GitHub Actions is responsible for handling missing args, not your entrypoint.sh.

@JamesIves
Copy link
Owner

I like the idea of this. I'm currently working on version 2 of this action so I'll probably push it in as part of that.

@mitinarseny
Copy link
Author

By the way, do you consider to move installation of dependencies (apt-get update && apt-get install -y git jq) to dockerfile and push your image with it on Docker Hub? It would save time on Github Actions to pass your action.

@JamesIves
Copy link
Owner

Currently the idea is to deprecate the Docker version of this action in favor of the Actions Toolkit. This will remove the requirement for these.

@JamesIves JamesIves added the planned 🕘 This feature is planned. label Oct 16, 2019
@JamesIves JamesIves added this to the Version 3 milestone Oct 16, 2019
@JamesIves
Copy link
Owner

Planned: #39

@JamesIves JamesIves self-assigned this Oct 16, 2019
@JamesIves JamesIves mentioned this issue Nov 7, 2019
@JamesIves
Copy link
Owner

Available in the v3 beta. Please give it a try and let me know if you encounter any problems.

JamesIves/github-pages-deploy-action@releases/v3-beta.

@JamesIves JamesIves added the version 3 Issues related to version 3 of this action. label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
planned 🕘 This feature is planned. version 3 Issues related to version 3 of this action.
Projects
None yet
Development

No branches or pull requests

2 participants