Fix for #2: Adding support for excluding <link> tags

jamesjieye · Dec 6, 2016 · 8814434 · 8814434
1 parent cf8157f
commit 8814434
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/index.js b/index.js
@@ -44,13 +44,13 @@ HtmlWebpackExcludeAssetsPlugin.prototype.processAssets = function (excludePatter
   var head = [];
 
   pluginData.head.forEach(function (tag) {
-    if (!self.isExcluded(excludePatterns, tag.attributes.src)) {
+    if (!self.isExcluded(excludePatterns, tag.attributes.src || tag.attributes.href)) {
       head.push(tag);
     }
   });
 
   pluginData.body.forEach(function (tag) {
-    if (!self.isExcluded(excludePatterns, tag.attributes.src)) {
+    if (!self.isExcluded(excludePatterns, tag.attributes.src || tag.attributes.href)) {
       body.push(tag);
     }
   });

diff --git a/spec/fixtures/exclude.css b/spec/fixtures/exclude.css
@@ -0,0 +1,3 @@
+.exclude {
+	font-size: 24px;
+}
diff --git a/spec/index.spec.js b/spec/index.spec.js
@@ -50,7 +50,8 @@ describe('HtmlWebpackExcludeAssetsPlugin', function () {
     webpack({
       entry: {
         app: path.join(__dirname, 'fixtures', 'entry.js'),
-        style: [path.join(__dirname, 'fixtures', 'app.css')]
+        styleInclude: path.join(__dirname, 'fixtures', 'app.css'),
+        styleExclude: path.join(__dirname, 'fixtures', 'exclude.css')
       },
       output: {
         path: OUTPUT_DIR,
@@ -62,7 +63,7 @@ describe('HtmlWebpackExcludeAssetsPlugin', function () {
       plugins: [
         new ExtractTextPlugin('[name].css'),
         new HtmlWebpackPlugin({
-          excludeAssets: [/style.*.js/]
+          excludeAssets: [/styleInclude.*.js/, /styleExclude.*.css/]
         }),
         new HtmlWebpackExcludeAssetsPlugin()
       ]
@@ -72,8 +73,9 @@ describe('HtmlWebpackExcludeAssetsPlugin', function () {
       fs.readFile(htmlFile, 'utf8', function (er, data) {
         expect(er).toBeFalsy();
         var $ = cheerio.load(data);
-        expect($('script[src="style.js"]').toString()).toBe('');
-        expect($('link[href="style.css"]').toString()).toBe('<link href="style.css" rel="stylesheet">');
+        expect($('script[src="styleInclude.js"]').toString()).toBe('');
+        expect($('link[href="styleInclude.css"]').toString()).toBe('<link href="styleInclude.css" rel="stylesheet">');
+        expect($('link[href="styleExclude.css"]').toString()).toBe('');
         done();
       });
     });