Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp formatting to match documentation #331

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

jameslittle230
Copy link
Owner

  • minutes_and_seconds is a supported config value
  • template string expects {} instead of {ts}

Closes #330

- minutes_and_seconds is a supported config value
- template string expects `{}` instead of `{ts}`
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #331 (fb8a559) into master (eeaca67) will increase coverage by 1.20%.
The diff coverage is 81.30%.

❗ Current head fb8a559 differs from pull request most recent head 39a546e. Consider uploading reports for the commit 39a546e to get more accurate results

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   72.44%   73.65%   +1.20%     
==========================================
  Files          53       52       -1     
  Lines        2174     2270      +96     
  Branches      104      108       +4     
==========================================
+ Hits         1575     1672      +97     
+ Misses        598      597       -1     
  Partials        1        1              
Impacted Files Coverage Δ
stork-cli/src/io.rs 0.00% <0.00%> (ø)
stork-cli/src/main.rs 0.00% <0.00%> (ø)
stork-lib/src/config/file.rs 96.47% <ø> (ø)
...data_source_readers/filepath_data_source_reader.rs 0.00% <0.00%> (ø)
...ries/data_source_readers/url_data_source_reader.rs 0.00% <0.00%> (ø)
stork-lib/src/index_v3/build/fill_stems.rs 100.00% <ø> (ø)
...rk-lib/src/index_v3/search/intermediate_excerpt.rs 0.00% <ø> (ø)
stork-lib/src/input.rs 98.61% <ø> (-1.39%) ⬇️
stork-lib/src/lib.rs 35.08% <0.00%> (ø)
stork-lib/src/index_v3/search/mod.rs 78.65% <33.33%> (-17.13%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jameslittle230 jameslittle230 changed the title Fix timestamp formatting to match documentaiton Fix timestamp formatting to match documentation Jan 10, 2023
@github-actions
Copy link

github-actions bot commented Jan 10, 2023

Benchmarks

BenchmarkBaselineContenderComparison
build/federalist168.1503166.90670.99× 🎉
federalist.st1125.4561125.4561.0×
search/federalist/liberty1.60671.57480.98× 🎉
stork.js23.12223.1221.0×
stork.wasm337.231337.2311.0×

Baseline: 8550f1f; Comparison: 39a546e

@jameslittle230 jameslittle230 merged commit a6b1752 into master Jan 10, 2023
@jameslittle230 jameslittle230 deleted the minutes-and-seconds-timestamp-format branch January 10, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working with Subtitles | timestamp_format "MinutesAndSeconds"
1 participant