Lift per_file_input_config outside of loop to avoid a potentially expensive clone #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My input config had 118,000 file object - each with DataSource::Contents - so we were spending tons (n * n) of time cloning here when it's not necessary
By hoisting the clone out of the loop and mutating thereafter, we avoid the expensive cloning.
This reduced my index build time from just under 3 hours to 55 seconds