Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of transaction() does not match redis-py #78

Closed
okey opened this issue May 6, 2015 · 0 comments
Closed

Behaviour of transaction() does not match redis-py #78

okey opened this issue May 6, 2015 · 0 comments

Comments

@okey
Copy link

okey commented May 6, 2015

Here is redis-py's transaction()

As you can see, it takes keyword arguments: def transaction(self, func, *watches, **kwargs)
fakeredis' transaction() does not expect keyword arguments: def transaction(self, func, *keys)

Naturally this results in a TypeError when trying to use keyword arguments.

The three current kwargs are shard_hint=None, value_from_callable=False, and watch_delay=None. The fakeredis implementation, however, does not support any of these.

nfvs added a commit to nfvs/fakeredis that referenced this issue Dec 10, 2015
Match the function signatures, add support for `value_from_callable`
and `watch_delay` kwargs. Add test for `value_from_callable`.

Fixes jamesls#78.
nfvs added a commit to nfvs/fakeredis that referenced this issue Dec 10, 2015
Match the function signatures, add support for `value_from_callable`
and `watch_delay` kwargs. Add test for `value_from_callable`.

Fixes jamesls#78.
nfvs added a commit to nfvs/fakeredis that referenced this issue Dec 10, 2015
Match the function signatures, add support for `value_from_callable`
and `watch_delay` kwargs. Add test for `value_from_callable`.

Fixes jamesls#78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants