Check keys exist before delete in _StrKeyDict._update_expired_keys #118
Conversation
I was running into an issue when use fakeredis and freezegun to manipulate dates in a unit test. The _StrKeyDict._update_expired_keys was trying to delete keys that appeared the _ex_keys dict, but somehow the keys did not appear in the underlying _dict of the class instance. This just updates the method to verify that the key is contained in the _ex_keys and _dict objects before calling del.
…xpired_keys Check keys before delete in _update_expired_keys
|
@mmcmahon-jana are you using django-redis for session by any chance? Because then the problem is related to #120 as I experienced the same behavior as you did together with freezegun. A potential fix would be to call |
|
@kairichard interesting, I'm not using django-redis but I will try the to_bytes fix you are suggesting to see if it makes a difference. Thanks. |
|
I've created a fork called fakenewsredis with a PyPI release to incorporate PRs that aren't getting traction here. I've included this #128 in fakenewsredis, which I think removes the need for this PR (but let me know if I've misunderstood the issue). |
|
Closing because the structure of the internal storage has changed in fakeredis 0.10.1, which should fix this issue. |
I was running into an issue when use fakeredis and freezegun to manipulate dates in a unit test. The _StrKeyDict._update_expired_keys was trying to delete keys that appeared the _ex_keys dict, but somehow the keys did not appear in the underlying _dict of the class instance.
This just updates the method to verify that the key is contained in the _ex_keys and _dict objects before calling del.
This method is called repeatedly while existing tests are run and I do not want to add a dependency on freezegun to recreate the circumstances of my specific bug. So I hope that this PR is ok without new tests.