Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests failing on 32 bits CPU archs #126

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Fix unit tests failing on 32 bits CPU archs #126

merged 1 commit into from
Sep 6, 2016

Conversation

onovy
Copy link
Contributor

@onovy onovy commented Sep 2, 2016

Without this patch, unit tests is failing on i686:

======================================================================
ERROR: test_pttl_should_return_value_for_expiring_key (test_fakeredis.TestFakeRedis)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/test_fakeredis.py", line 2675, in test_pttl_should_return_value_for_expiring_key
    self.redis.expire('foo', long_long_c_max)
  File "fakeredis.py", line 272, in expire
    return self._expire(name, time)
  File "fakeredis.py", line 281, in _expire
    raise redis.ResponseError("value is not an integer or out of "
ResponseError: value is not an integer or out of range.

======================================================================
ERROR: test_ttl_should_return_value_for_expiring_key (test_fakeredis.TestFakeRedis)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/test_fakeredis.py", line 2658, in test_ttl_should_return_value_for_expiring_key
    self.redis.expire('foo', long_long_c_max)
  File "fakeredis.py", line 272, in expire
    return self._expire(name, time)
  File "fakeredis.py", line 281, in _expire
    raise redis.ResponseError("value is not an integer or out of "
ResponseError: value is not an integer or out of range.

======================================================================
ERROR: test_pttl_should_return_value_for_expiring_key (test_fakeredis.TestFakeRedisDecodeResponses)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/test_fakeredis.py", line 2675, in test_pttl_should_return_value_for_expiring_key
    self.redis.expire('foo', long_long_c_max)
  File "fakeredis.py", line 194, in decode_response
    val = _decode(func(*args, **kwargs))
  File "fakeredis.py", line 272, in expire
    return self._expire(name, time)
  File "fakeredis.py", line 281, in _expire
    raise redis.ResponseError("value is not an integer or out of "
ResponseError: value is not an integer or out of range.

======================================================================
ERROR: test_ttl_should_return_value_for_expiring_key (test_fakeredis.TestFakeRedisDecodeResponses)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/.pybuild/pythonX.Y_2.7/build/test_fakeredis.py", line 2658, in test_ttl_should_return_value_for_expiring_key
    self.redis.expire('foo', long_long_c_max)
  File "fakeredis.py", line 194, in decode_response
    val = _decode(func(*args, **kwargs))
  File "fakeredis.py", line 272, in expire
    return self._expire(name, time)
  File "fakeredis.py", line 281, in _expire
    raise redis.ResponseError("value is not an integer or out of "
ResponseError: value is not an integer or out of range.

----------------------------------------------------------------------
Ran 1165 tests in 78.766s

FAILED (SKIP=580, errors=4)

@jamesls
Copy link
Owner

jamesls commented Sep 2, 2016

Looks like this is failing on travis, any ideas? https://travis-ci.org/jamesls/fakeredis/builds/157205722

@coveralls
Copy link

coveralls commented Sep 3, 2016

Coverage Status

Coverage remained the same at 98.153% when pulling 291b5dc on onovy:32b_fix into 913d987 on jamesls:master.

@onovy
Copy link
Contributor Author

onovy commented Sep 3, 2016

fixed on 32, broke on 64 :).

Pushed new version

@jamesls jamesls merged commit 4bfc7a2 into jamesls:master Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants