Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all flake8 errors and added flake8 to Travis CI #139

Closed
wants to merge 1 commit into from
Closed

Fixed all flake8 errors and added flake8 to Travis CI #139

wants to merge 1 commit into from

Conversation

jdufresne
Copy link
Contributor

No description provided.

Copy link

@TereFDS TereFDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Apart removing unused import, maybe It could be interesting to remove the things not compliant with pep8 (you can use pep8 or flake8 to achieve this)

@jdufresne
Copy link
Contributor Author

Thanks for the suggestion. Done. I have updated the PR to include a fix for all flake8 errors. I have also updated the Travis CI to include flake8 on PRs.

@jdufresne jdufresne changed the title Remove unused import from setup.py Fixed all flake8 errors and added flake8 to Travis CI Feb 7, 2017
@bmerry
Copy link
Collaborator

bmerry commented Nov 10, 2017

I've created a fork called fakenewsredis with a PyPI release to incorporate PRs that aren't getting traction here. I've included this PR.

@jdufresne
Copy link
Contributor Author

I have rebased to resolve merge conflicts. Ready for review.

@bmerry
Copy link
Collaborator

bmerry commented Mar 22, 2018

Closing because this has been merged into 0.10.1 (via the fakenewsredis fork).

@bmerry bmerry closed this Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants