-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock connection error #197
Merged
Merged
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bb70bcd
Started implementing connection error throws
Amertz08 6aea29c
updated test cases
Amertz08 5359bdf
Updated ConnectionError test cases
Amertz08 f940176
Updated test case to actually fail when decorator does not exist inst…
Amertz08 17a98dd
Merge branch 'master' into 102-mock-connection-error
Amertz08 ffb6205
Added venv to ignore file
Amertz08 4263daa
Added missing check_conn so tests work
Amertz08 2164cb6
Updated tests and added check decorator as needed
Amertz08 cbaba98
finished remaining tests
Amertz08 ef97612
flake8
Amertz08 269fc1c
Fixed issue with decorator not playing well with _lua_reply
Amertz08 49db0a3
Modified _patch_responses to take the decorator as a parameter
Amertz08 5dccd2a
Made connection check decorator private function. Adjusted for use th…
Amertz08 c1a80b3
Removed decorator from methods
Amertz08 fa63151
Adjusted patch_responses call for FakePubSub class
Amertz08 0fa4e3c
Adjusted test cases for access to connected attribute
Amertz08 ed56f4a
Connection error decorator should be patched to response regardless o…
Amertz08 dc3e59e
ConnectionError message
Amertz08 bfe919b
Updated README with documentation on mocking connection errors
Amertz08 03615de
Proper indentation in README
Amertz08 71e89ba
_check_conn should be patched on before decode_responses
Amertz08 8412e25
Spacing fix on documentation
Amertz08 6f301b3
Patched connection error decorator to PubSub class. Added test cases
Amertz08 75dced3
Connected arg after decode arg in FakePubSub
Amertz08 28cae30
Renamed test attribute redis to pubsub
Amertz08 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,3 +4,5 @@ dump.rdb | |
extras/* | ||
.tox | ||
*.pyc | ||
.idea | ||
venv/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather put
connected
afterdecode_responses
, so that it doesn't break existing code that passes decode_responses as a positional parameter.